-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [Fix] Constant reconciles due to Catalog's poll interval #812
🐛 [Fix] Constant reconciles due to Catalog's poll interval #812
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8c2f06c
to
337f73f
Compare
337f73f
to
22962fd
Compare
Due to the polling feature in the Catalog, the `lastPolledInterval` in the Catalog's status gets updated. Because of this there is a reconcile is trigrred every time the catalog is polled, even though there is no change in the resolved image ref SHA. This causes unnecessary continuous reconciles in the CE. To overcome this, a Predicate is added to accept update events only when there is a change in Resolved reference. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
22962fd
to
f1da0d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
==========================================
+ Coverage 67.21% 71.04% +3.83%
==========================================
Files 23 16 -7
Lines 1467 1278 -189
==========================================
- Hits 986 908 -78
+ Misses 415 300 -115
- Partials 66 70 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Description
Due to the polling feature in the Catalog, the
lastPolledInterval
in the Catalog's status gets updated. Because of this there is a reconcile triggered every time the catalog is polled, even though there is no change in the resolved image ref.This causes unnecessary continuous reconciles in the CE reconciler. To overcome this, a Predicate is added to accept update events only when there is a change in Resolved image reference in catalog's status.
Reviewer Checklist